Handling newline characters in tags #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
============================================
+ Coverage 59.09% 59.18% +0.08%
- Complexity 413 419 +6
============================================
Files 69 70 +1
Lines 2540 2548 +8
Branches 268 270 +2
============================================
+ Hits 1501 1508 +7
Misses 972 972
- Partials 67 68 +1
Continue to review full report at Codecov.
|
|
@fmachado So how is this one? Good enough? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is the last one I have to do to clean up #684. Another attempt was made at #702, but checkstyle made things...difficult.